Skip to content
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

Export Context type from types.ts instead of walkTree.ts. #2832

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Export Context type from types.ts instead of walkTree.ts. #2832

merged 2 commits into from
Mar 1, 2019

Conversation

@benjamn
Copy link
Member

@benjamn benjamn commented Mar 1, 2019

When we stopped reexporting everything from walkTree.ts as part of #2533, we also stopped exporting the Context type that it uses.

Moving the declaration and export of Context from walkTree.ts to types.ts restores the ability to do

import { Context } from "react-apollo"

which should fix #2824.

@benjamn
Export Context type from types.ts instead of walkTree.ts.
8bbf8e5 
When we stopped reexporting everything from walkTree.ts as part of #2533,
we also stopped exporting the Context type that it uses.

Moving the declaration and export of Context from walkTree.ts to types.ts
restores the ability to do

  import { Context } from "react-apollo"

which should fix #2824.
@benjamn benjamn self-assigned this Mar 1, 2019
@benjamn benjamn requested a review from hwillson as a code owner March 1, 2019 20:53
@benjamn benjamn mentioned this pull request Mar 1, 2019
Closed
@benjamn benjamn merged commit ce333cd into master Mar 1, 2019
@benjamn benjamn deleted the issue-2824-restore-Context-type-export branch March 1, 2019 21:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hwillson hwillson Awaiting requested review from hwillson

1 more reviewer

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@benjamn benjamn

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breaking typescript change in 2.5

2 participants

@benjamn @VincentLanglet