Skip to content

Conversation

@TroyWalshProf
Copy link
Contributor

Change list

Add missing MobileBy.ClassName and TagName

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Add missing implementations of MobileBy ClassName and TagName

@TroyWalshProf TroyWalshProf changed the title Add and test missing mobile Bys chore: Add and test missing mobile Bys Oct 20, 2021
@TroyWalshProf TroyWalshProf changed the title chore: Add and test missing mobile Bys fix: Add and test missing mobile Bys Oct 20, 2021
@TroyWalshProf
Copy link
Contributor Author

@akinsolb - Ready for review

public class ByTagName : MobileBy
{
/// <summary>
/// Initializes a new instance of the <see cref="ById"/> class.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it?

@laolubenson laolubenson merged commit c03b720 into appium:release/5.0.0 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants