Remove majority of @unchecked Sendable usages
#295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation `@unchecked Sendable` is a great way to make a type `Sendable` while it is not really `Sendable` this is rarely useful and we should rather use conditional `@unchecked Sendable` annotations such as the one on `ManagedCriticalState` # Modification This PR removes all `@unchecked Sendable` in the main algorithm target except the one on `Merge` since we are doing manual locking there. # Result No more `@unchecked Sendable` usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@unchecked Sendableis a great way to make a typeSendablewhile it is not reallySendablethis is rarely useful and we should rather use conditional@unchecked Sendableannotations such as the one onManagedCriticalStateModification
This PR removes all
@unchecked Sendablein the main algorithm target except the one onMergesince we are doing manual locking there.Result
No more
@unchecked Sendableusage.