build: Make swift-crypto build on Windows #385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Jul 22, 2025
|
Will rebase once #386 lands. |
Make swift-crypto build on Windows - [X] I've run tests to see all new and existing tests pass - [X] I've followed the code style of the rest of the project - [X] I've read the [Contribution Guidelines](CONTRIBUTING.md) - [X] I've updated the documentation if necessary - [N/A] I've run `.script/generate_boilerplate_files_with_gyb` and included updated generated files in a commit of this pull request Currently, swift-crypto on the main branch does not build on Windows. * Add the Windows Arm64 assembly files to the CMake build. * Add appropriate CMake options for swift-crypto to build on Windows. swift-crypto can be built on Windows from main Fixes apple#369 --------- Co-authored-by: Cory Benfield <[email protected]> (cherry picked from commit 9934678)
etcwilde
force-pushed
the
ewilde/3.12.x-Windows-arm-sources
branch
from
d383aa5 to
26c4198
Compare
Steelskin
added a commit
to Steelskin/swift
that referenced
this pull request
Jul 23, 2025
Changelog: * apple/swift-crypto@d79c573 Make Build: Disable CMP0157 (apple/swift-crypto#387) * apple/swift-crypto@ebcbfc6 build: Make swift-crypto build on Windows (apple/swift-crypto#385) * apple/swift-crypto@785709b Fix broken Windows tests (apple/swift-crypto#350) (apple/swift-crypto#386)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make swift-crypto build on Windows
I've run tests to see all new and existing tests pass
I've followed the code style of the rest of the project
I've read the Contribution Guidelines
I've updated the documentation if necessary
[N/A] I've run
.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestCurrently, swift-crypto on the main branch does not build on Windows.
swift-crypto can be built on Windows from main
Fixes #369
Co-authored-by: Cory Benfield [email protected]
(cherry picked from commit 9934678) (#370)