Use per-type imports everywhere #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The PR #184 broke the build when Foundation.Date was used in specific locations on client/server.
Modifications
Fixed the bug, but also made things even more consistent by using per-type imports on all platforms.
Result
All the necessary Foundation imports are now present, plus code got simplified a bit.
Test Plan
Now that all platforms emit the same imports (except for the
@preconcurrencyattribute), it's easier to catch similar issues even during local dev. Verified on a sample proj this now works correctly.Updated reference tests.