Split client and server examples into separate packages #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czechboy0
approved these changes
Oct 3, 2023
Contributor
czechboy0
left a comment
czechboy0
left a comment
There was a problem hiding this comment.
That's a good idea, let's do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The client and server examples currently live in a single Swift package. The majority of adopters will probably want to crib from an example of a client or a server, and having them together runs the risk of them cargo-culting dependencies they don't need. The current setup also prevents us from updating the dependencies in the client example if the server transport releases are lagging.
Modifications
Result
Client example package is updated to latest dependencies and can build.
Test Plan
Tested that both packages can build locally.