Skip to content

Conversation

@czechboy0
Copy link
Contributor

Motivation

Fixes #312.

Modifications

Explicitly skip binary properties in codable structs.

Result

Remove build failures for projects using multipart.

Test Plan

Created a unit test.

Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice snippet test too!

@czechboy0
Copy link
Contributor Author

@swift-server-bot test this please

2 similar comments
@czechboy0
Copy link
Contributor Author

@swift-server-bot test this please

@yim-lee
Copy link
Member

yim-lee commented Oct 3, 2023

@swift-server-bot test this please

@czechboy0 czechboy0 enabled auto-merge (squash) October 3, 2023 16:30
@czechboy0 czechboy0 added this to the 0.3.0 milestone Oct 3, 2023
@czechboy0 czechboy0 merged commit cb36339 into apple:main Oct 3, 2023
@czechboy0 czechboy0 deleted the hd-skip-binary-properties branch October 3, 2023 16:57
@czechboy0 czechboy0 added the 🆕 semver/minor Adds new public API. label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 semver/minor Adds new public API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip type: string + format: binary in object properties

3 participants