[BUG] Fix: resolve issue with HTTP headers may lost some cookies #50
Conversation
| } | ||
| self.init(url: url) | ||
| self.httpMethod = request.method.rawValue | ||
| for header in request.headerFields { setValue(header.value, forHTTPHeaderField: header.name.canonicalName) } |
There was a problem hiding this comment.
Would it also get fixed if we used the addValue API instead? https://developer.apple.com/documentation/foundation/urlrequest/2011522-addvalue
There was a problem hiding this comment.
It seems that the addValue API might be a better option. ChatGPT suggested something related to Cookie and Set-Cookie headers, but I didn’t find any relevant information in the official documentation. I’m not sure if there might be other issues involved here.
There was a problem hiding this comment.
addValue use , but cookie needs ; 💔
There was a problem hiding this comment.
@guoye-zhang can you help here?
There was a problem hiding this comment.
I opened #51 and borrowed the code to do the correct transaction from swift-http-types
|
@anotheren let's close this and use #51, thanks for pushing for this fix! 👏 |
3 participants
Motivation
I use a custom
ClientMiddlewareto inject cookie for some APIs, but I found the final Request always lost some cookies.https://github.com/apple/swift-http-types/blob/e6359663d11a5c7d2340ac81f2e025d5c5fb0e14/Sources/HTTPTypes/HTTPFields.swift#L190
The reason is that there may be more than one cookie in the
HTTPRequest'sheaderFields. Before setting them to theURLRequest, you must join them together. Otherwise, only the last cookie will be effective due to simple overwriting.Modifications
Check
header.namebefore setting it to theURLRequestResult
All cookies now work well.
Test Plan
Not yet.