Skip to content

Conversation

ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Aug 30, 2025

What does this PR do?

When the limit range is not defined for integer and float columns, backend uses PHP's limits which goes way out of bounds on Console. This fixes it.

Test Plan

Manual -

Screen.Recording.2025-08-30.at.11.50.11.AM.mov

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • New Features

    • Increased precision for generated double values from 2 to 4 decimal places.
  • Bug Fixes

    • Numeric data generation now constrained to safe ranges to prevent unrealistic or overflow values.
    • Adjusted default ranges for integers and doubles to produce more reliable mock data.
    • Standardized handling of floating-point type as “double” for consistency.

Copy link

appwrite bot commented Aug 30, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-qa
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

You can use Avatars API to generate QR code for any text or URLs.

@ItzNotABug ItzNotABug self-assigned this Aug 30, 2025
Copy link
Contributor

coderabbitai bot commented Aug 30, 2025

Walkthrough

Adds a new helper src/lib/helpers/numbers.ts exporting isWithinSafeRange(val: number). Updates src/lib/helpers/faker.ts to import and use this helper when generating numbers: for integers, min defaults to 0 and max to 100 if provided values are outside the safe range; previous defaults were 0 and 10000 when undefined. Renames the 'float' case to 'double' and applies the same safe-range defaults, increases precision from 2 to 4, and generates values via faker.number.float with fractionDigits: 4. Other types remain unchanged.

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-float-data

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7aecc53 and 6245b2e.

📒 Files selected for processing (2)
  • src/lib/helpers/faker.ts (2 hunks)
  • src/lib/helpers/numbers.ts (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/lib/helpers/faker.ts (1)
src/lib/helpers/numbers.ts (1)
  • isWithinSafeRange (36-38)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build
🔇 Additional comments (2)
src/lib/helpers/faker.ts (2)

5-5: LGTM: shared numeric guard import.


176-183: Include both 'float' and 'double' cases and normalize bounds

  • Add case 'float': above case 'double': and compute
    const rawMin = isWithinSafeRange(floatAttr.min) ? floatAttr.min : 0;
    const rawMax = isWithinSafeRange(floatAttr.max) ? floatAttr.max : 100;
    const min = Math.min(rawMin, rawMax);
    const max = Math.max(rawMin, rawMax);
    return faker.number.float({ min, max, fractionDigits: 4 });
    to avoid inverted ranges.
  • No 'float' discriminant was found in the current codebase—please verify if adding it is required.

@ItzNotABug ItzNotABug merged commit bf5ff13 into main Aug 30, 2025
5 checks passed
@ItzNotABug ItzNotABug deleted the fix-float-data branch August 30, 2025 06:54
@coderabbitai coderabbitai bot mentioned this pull request Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants