-
Notifications
You must be signed in to change notification settings - Fork 191
fix: hide email verification banner on wizard pages #2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hide email verification banner on wizard pages #2372
Conversation
ConsoleProject ID: Sites (2)
Note You can use Avatars API to generate QR code for any text or URLs. |
WalkthroughUpdates src/lib/components/alerts/emailVerificationBanner.svelte to import Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/lib/components/alerts/emailVerificationBanner.svelte (1)
13-13
: Guard against undefined store values; simplify the gate.If the store shape changes or initializes lazily,
.$wizard.show
could throw. Safer and terser:-const notOnWizard = $derived(!$wizard.show && !$isNewWizardStatusOpen); +const notOnWizard = $derived(!($wizard?.show || $isNewWizardStatusOpen));
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/lib/components/alerts/emailVerificationBanner.svelte
(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
src/lib/components/alerts/emailVerificationBanner.svelte
[warning] 1-1: Prettier formatting issues detected in 'src/lib/components/alerts/emailVerificationBanner.svelte'. Run 'prettier --write' to fix.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e
🔇 Additional comments (3)
src/lib/components/alerts/emailVerificationBanner.svelte (3)
14-14
: Condition tightening matches the requirement.Adding
notOnWizard
toshouldShowEmailBanner
correctly hides the banner during wizard flows.
1-34
: Prettier formatting appliedRan npx prettier --write src/lib/components/alerts/emailVerificationBanner.svelte — file was formatted; CI formatting check should pass now.
8-8
: Import verified — exports present and no runtime circular dependencyBoth
wizard
andisNewWizardStatusOpen
are exported from src/lib/stores/wizard.ts (exports at lines 102 and 104). wizard.ts only uses a type-only import from $lib/layout/wizardWithSteps.svelte, so there is no runtime circular import.
What does this PR do?
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
yes
Summary by CodeRabbit