Skip to content

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Sep 15, 2025

What does this PR do?

image image image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

yes

Summary by CodeRabbit

  • Bug Fixes
    • Email verification banner no longer appears while the setup wizard is active or when a new wizard status is open, preventing overlap and reducing distraction.
    • Banner now only displays in Cloud environments.
    • Existing visibility rules preserved: it shows only for signed-in users who need verification and who are not on onboarding.

Copy link

appwrite bot commented Sep 15, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-qa
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

You can use Avatars API to generate QR code for any text or URLs.

Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Walkthrough

Updates src/lib/components/alerts/emailVerificationBanner.svelte to import wizard and isNewWizardStatusOpen, add a derived notOnWizard = $derived(!$wizard.show && !$isNewWizardStatusOpen), and tighten the banner visibility condition from hasUser && needsEmailVerification && notOnOnboarding to isCloud && hasUser && needsEmailVerification && notOnOnboarding && notOnWizard. No exported/public API changes; existing state and rendering logic remain the same aside from the added gating.

Possibly related PRs

Suggested reviewers

  • stnguyen90
  • ItzNotABug

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix: hide email verification banner on wizard pages" accurately and succinctly describes the primary change. The changeset updates emailVerificationBanner.svelte to add a wizard-related gating condition so the banner is not displayed during wizard flows. The wording is specific, clear, and appropriate for changelog/PR history scanning.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-SER-391-hide-email-verification-banner-on-wizard-pages

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbaaac6 and 32ea7fa.

📒 Files selected for processing (1)
  • src/lib/components/alerts/emailVerificationBanner.svelte (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/lib/components/alerts/emailVerificationBanner.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/lib/components/alerts/emailVerificationBanner.svelte (1)

13-13: Guard against undefined store values; simplify the gate.

If the store shape changes or initializes lazily, .$wizard.show could throw. Safer and terser:

-const notOnWizard = $derived(!$wizard.show && !$isNewWizardStatusOpen);
+const notOnWizard = $derived(!($wizard?.show || $isNewWizardStatusOpen));
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bb11a3 and 79e006c.

📒 Files selected for processing (1)
  • src/lib/components/alerts/emailVerificationBanner.svelte (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Tests
src/lib/components/alerts/emailVerificationBanner.svelte

[warning] 1-1: Prettier formatting issues detected in 'src/lib/components/alerts/emailVerificationBanner.svelte'. Run 'prettier --write' to fix.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: e2e
🔇 Additional comments (3)
src/lib/components/alerts/emailVerificationBanner.svelte (3)

14-14: Condition tightening matches the requirement.

Adding notOnWizard to shouldShowEmailBanner correctly hides the banner during wizard flows.


1-34: Prettier formatting applied

Ran npx prettier --write src/lib/components/alerts/emailVerificationBanner.svelte — file was formatted; CI formatting check should pass now.


8-8: Import verified — exports present and no runtime circular dependency

Both wizard and isNewWizardStatusOpen are exported from src/lib/stores/wizard.ts (exports at lines 102 and 104). wizard.ts only uses a type-only import from $lib/layout/wizardWithSteps.svelte, so there is no runtime circular import.

@ItzNotABug ItzNotABug merged commit 50382a2 into main Sep 15, 2025
5 checks passed
@ItzNotABug ItzNotABug deleted the fix-SER-391-hide-email-verification-banner-on-wizard-pages branch September 15, 2025 13:55
This was referenced Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants