Skip to content

Conversation

HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Sep 27, 2025

What does this PR do?

I applied the same fix pattern used in PR #2336 for the team ID issue:

Test Plan

image

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

yes

Summary by CodeRabbit

  • New Features
    • None.
  • Bug Fixes
    • Improved function creation flow to gracefully handle missing or unset IDs across manual, repository, and template creation paths.
    • Ensures an ID is auto-generated when absent, preventing errors and interruptions during setup.
  • Refactor
    • Internal adjustments to support nullable IDs for a more robust creation experience.
  • Documentation
    • None.
  • Tests
    • None.
  • Chores
    • None.
  • Revert
    • None.

Copy link

appwrite bot commented Sep 27, 2025

Console

Project ID: 688b7bf400350cbd60e9

Sites (2)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code
 console-cloud
688b7c18002b9b871a8f
Ready Ready View Logs Preview URL QR Code

Note

Appwrite has a Discord community with over 16 000 members.

Copy link
Contributor

coderabbitai bot commented Sep 27, 2025

Walkthrough

Across several Svelte components involved in function creation, the id variable/type was updated to support null. In details.svelte, the exported prop changed from string to string | null. In manual/+page.svelte, repository-[repository]/+page.svelte, and template-[template]/+page.svelte, local id declarations were changed to string | null and initialized to null. Existing logic that uses id || ID.unique() remains, accommodating the nullable type. No new exports were introduced and no additional control-flow changes were made.

Suggested reviewers

  • ItzNotABug

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “fix(functions): initialize function id to null” accurately and concisely captures the primary change of updating the function ID default to null across the components, matches the commit scope and intent, and uses clear conventional commit formatting.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-SER-411-unable-to-set-custom-function-id

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efe0321 and f247033.

📒 Files selected for processing (4)
  • src/routes/(console)/project-[region]-[project]/functions/create-function/(components)/details.svelte (1 hunks)
  • src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte (1 hunks)
  • src/routes/(console)/project-[region]-[project]/functions/create-function/repository-[repository]/+page.svelte (1 hunks)
  • src/routes/(console)/project-[region]-[project]/functions/create-function/template-[template]/+page.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: e2e
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ItzNotABug ItzNotABug merged commit c35f469 into main Sep 27, 2025
5 checks passed
@ItzNotABug ItzNotABug deleted the fix-SER-411-unable-to-set-custom-function-id branch September 27, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants