-
Notifications
You must be signed in to change notification settings - Fork 189
Fix: double increment and decrement. #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ConsoleProject ID: Sites (2)
Note Cursor pagination performs better than offset pagination when loading further pages. |
Walkthrough
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (1)
296-324
: Add missing ‘float’ case to getAppropriateIcon
The switch removed handling for"float"
, but front-end still usestype: 'float'
in multiple places (e.g. store.ts, float.svelte), so any float column will now render no icon. Re-add:function getAppropriateIcon(type: string): ComponentType { switch (type) { case 'string': return IconText; case 'double': + case 'float': // support existing float columns case 'integer': return IconHashtag; …
[src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte#L296-324]
🧹 Nitpick comments (1)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte (1)
34-34
: Conditional step value for integer vs. double is appropriate.
Usingstep={column.type === 'double' ? 0.1 : 1}
gives sensible defaults for whole‐number and one‐decimal increments. If you anticipate use cases needing finer precision, consider making the step configurable (e.g. derived from acolumn.precision
field or defaulting to 0.01/0.001).
Optional: since this component handles both integer and floating types, renaminginteger.svelte
to something likenumber.svelte
could improve clarity in a future refactor.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/columns/types/integer.svelte
(1 hunks)src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build
- GitHub Check: e2e
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)
Summary by CodeRabbit