feat: rework node runtimes versionning to follow node versions #91
+22
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a work of the node versionning as only node runtime 14.5 followed the the node version.
All the others node runtimes versions are
vXX.0and the node version is NOTvXX.0(for example runtimev20.0is nodev20.17and notv20.0)To resolve this i followed this pattern:
node-<major>: use thenode:<major>-alpineimage (may change to keep it as the latest major)node-<major>.0: use thenode:<major>.0.0-alpine<alpVersion>(always include a first minor at 0)node-<major>.<minor>: use thenode:<major>.<minor>.<patch>-alpine<alpVersion>(can be created when new node images are created, should never change as thoses use the whole version with patches)Test Plan
The runtimes tests where done through the
open-runtimes/open-runtimesproject.I checked with files diff and multiple AIs to check if i didn't miss any versions in this project.
Related PRs and Issues
OpenRuntimes PR : open-runtimes/open-runtimes#413
Issues : open-runtimes/open-runtimes#412 and #89 as it will add the latest node 20/22/24
Additionnal Infos
Like i said in the openruntimes PR, i modeified the existing node runtimes to match the new pattern, tho it might break exiting project as the node version is lower than before (since before runtime
v20.0was nodev20.17now with the new pattern it will be nodev20.0for that runtime), if you prefer i can omit the changes on the existing runtimes to avoid breaking existing functions/sites.And if i need to change it, please tell me if you would like me to rewrite the commits or just add a new commit that bring the old runtimes back.
Have you read the Contributing Guidelines on issues?
yes