-
Notifications
You must be signed in to change notification settings - Fork 189
fix: import in swift and apple docs #1237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughConditional import blocks were removed from two documentation template files. The templates previously wrapped imports for Permission and Role (named from Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes conditional import logic for Permission and Role types from documentation template examples in Swift and .NET. The changes eliminate the hasPermissionParam conditional checks that previously controlled whether permission-related imports were included in generated documentation.
Key changes:
- Removed conditional permission/role import blocks from Swift documentation templates
- Removed conditional permission/role import blocks from .NET documentation templates
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| templates/swift/docs/example.md.twig | Removed conditional import block for Permission and Role classes |
| templates/dotnet/docs/example.md.twig | Removed conditional import block for Permission and Role namespaces |
Comments suppressed due to low confidence (2)
templates/swift/docs/example.md.twig:1
- The removal of conditional permission imports may cause documentation examples to fail if Permission or Role types are referenced in method parameters but no longer imported. Verify that these imports are now handled elsewhere (e.g., always included or imported through another mechanism) to ensure generated examples remain valid.
import {{ spec.title | caseUcfirst }}
templates/dotnet/docs/example.md.twig:1
- The removal of conditional permission using statements may cause documentation examples to fail if Permission or Role types are referenced in method parameters but no longer imported. Verify that these using statements are now handled elsewhere (e.g., always included or imported through another mechanism) to ensure generated examples remain valid.
using {{ spec.title | caseUcfirst }};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary by CodeRabbit