Small TestEm3 refactoring #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Contributor
|
Ok with me, but can you please write a proper commit message why you're making these changes? Not just "Refactoring"... |
Add const in a few places, remove an intermediate variable and use a lambda call to mark a track's survival. This increases readability.
Contributor
Author
|
I went with a simple commit message since the changeset is small and not a functional change. But I am fine with elaborating! |
1 task
hahnjo
approved these changes
Jun 2, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a small refactoring to the TestEm3 examples that helps me with my downstream work. It adds
constin a few places, contracts a variable and makes the survival of a track more visible.