Skip to content

Remove unnecessary store and unused variable in example19 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Remove unnecessary store and unused variable in example19 #224

merged 2 commits into from
Oct 6, 2022

Conversation

@bernhardmgruber
Copy link
Contributor

@bernhardmgruber bernhardmgruber commented Sep 30, 2022

No description provided.

@phsft-bot
Copy link

phsft-bot commented Sep 30, 2022

Can one of the admins verify this patch?

bernhardmgruber
bernhardmgruber commented Sep 30, 2022
View reviewed changes
@bernhardmgruber bernhardmgruber marked this pull request as ready for review September 30, 2022 12:26
@bernhardmgruber bernhardmgruber mentioned this pull request Sep 30, 2022
Closed
1 task
@hahnjo
Copy link
Contributor

hahnjo commented Oct 3, 2022

True, the first store of numIALeft is not needed - maybe the second was only executed conditionally at some point? Not sure...

But this improvement applies to all examples, no?

@bernhardmgruber
Copy link
Contributor Author

bernhardmgruber commented Oct 3, 2022

True, the first store of numIALeft is not needed - maybe the second was only executed conditionally at some point? Not sure...

That is also what I thought of.

But this improvement applies to all examples, no?

It probably does. Do you want me to apply this change set to other examples as well? Which ones?

@hahnjo
Copy link
Contributor

hahnjo commented Oct 4, 2022

But this improvement applies to all examples, no?

It probably does. Do you want me to apply this change set to other examples as well? Which ones?

The most recent examples probably, that we run comparisons against: example13 and example18 (in addition to example19) for the standalone cases, and example14 for the integration example (maybe also example17, but we know that this one is broken so it should not be used anyways...)

@bernhardmgruber
Copy link
Contributor Author

bernhardmgruber commented Oct 4, 2022

I applied the change to the other suggested examples as well.

@bernhardmgruber bernhardmgruber requested a review from hahnjo October 4, 2022 16:41
@hahnjo hahnjo merged commit f8d6af1 into apt-sim:master Oct 6, 2022
@bernhardmgruber bernhardmgruber deleted the improv_master branch October 6, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo hahnjo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernhardmgruber @phsft-bot @hahnjo