Skip to content

Conversation

@crash-g
Copy link

@crash-g crash-g commented Jan 11, 2019

Max number of connections is 20 if the protocol is null. Better to add explicit initialization.

@OmarAyo
Copy link

OmarAyo commented Jan 21, 2019

Hi @crash-g

Many thanks for contributing. We are obliged by law to have a signed scanned copy of a Contributor License Agreement (CLA) to be able to accept pull requests to the official ArangoDB repository - even for such small changes.

We use an Apache 2 CLA for ArangoDB and its companion projects, which can be found here: https://www.arangodb.com/documents/cla.pdf
Just fill in the form, sign and send a scanned copy over to [email protected]

Thank you

@crash-g
Copy link
Author

crash-g commented Feb 12, 2019

Hi,
sorry for the late reply. For such a small fix it is probably easier if you just close this pull request and include it as part of some other branch then.
Thanks!

@rashtao
Copy link
Collaborator

rashtao commented Sep 16, 2019

Implemented here:

getProperty(properties, PROPERTY_KEY_PROTOCOL, currentValue, ArangoDefaults.DEFAULT_NETWORK_PROTOCOL)

@rashtao rashtao closed this Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants