Skip to content

Feature/named indices #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 23, 2019
Merged

Feature/named indices #283

merged 6 commits into from
Jul 23, 2019

Conversation

hkernbach
Copy link
Member

No description provided.

@hkernbach hkernbach added this to the 3.5 milestone Jul 22, 2019
@hkernbach hkernbach requested a review from BCaxelbecker July 22, 2019 14:14
@hkernbach hkernbach requested a review from mchacki July 23, 2019 15:03
mchacki
mchacki requested changes Jul 23, 2019
View reviewed changes
Copy link
Member

@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM
I am missing some JavaDoc comments on all getName functions.
The setter has these comments though.

@hkernbach hkernbach merged commit e9ee119 into master Jul 23, 2019
@rashtao rashtao deleted the feature/named-indices branch September 16, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchacki mchacki mchacki requested changes

@BCaxelbecker BCaxelbecker Awaiting requested review from BCaxelbecker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@hkernbach @mchacki