Skip to content

Conversation

@carlsverre
Copy link

Questions/notes:

  • does ruby gem spec format support SPDX license expression? would be nice to normalize on that across all the packages
  • this is far from tested, but I wanted to get it up quickly for review
  • for readmes it might be better to let the user specify a readme path per target? (for relevant targets)

@asg017
Copy link
Owner

asg017 commented Apr 9, 2025

Hey this all looks great! Happy to merge whenever you think it's ready.

does ruby gem spec format support SPDX license expression? would be nice to normalize on that across all the packages

I believe so - https://guides.rubygems.org/specification-reference

this is far from tested, but I wanted to get it up quickly for review

This is awesome so far — don't worry too much about testing, I usually just manually do it. There isn't many great ways to test publishing to npm/gem/pip without just publishing and seeing if it works. I have this throwaway extension that I use to test "for real", along with a ton of -alpha.X releases.

for readmes it might be better to let the user specify a readme path per target? (for relevant targets)

100% yes! Would love to add an option like:

[targets]
pip = { readme_path = "docs/README.pip.md" }

npm = {readme_path = "docs/README.npm.md"}

gem = { module_name = "SqliteVec", readme_path = "docs/README.gem.md" }

etc etc. I also like defaulting to the description field if those are not provided.

@carlsverre
Copy link
Author

I think this is ready then. The Ruby license issue seems to be null - it appears that the license: field just writes directly into licenses: which is what you already are doing. It also sounds like Ruby doesn't really validate licenses so a SPDX expression should be just fine.

Let's push readmes to another task. I'd like to get this out asap in order to start using the builds. Do you mind testing this with your throwaway extension?

@carlsverre
Copy link
Author

@asg017 any chance we could get this landed so I can close out orbitinghail/graft#55

Appreciate it!

@carlsverre
Copy link
Author

I've uploaded a manual binary release of sqlite-dist to unblock graft#55

@carlsverre
Copy link
Author

@asg017 any chance this could land? I've been running an unofficial release for awhile now and it seems to be working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants