Convert vk_bitflags_wrapped! methods to const fn
#549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, union, and difference const fn methods. Implements #546 in upstream.
MarijnS95
reviewed
Jan 9, 2022
MarijnS95
changed the title
vk_bitflags_wrapped! methods to const fn
MarijnS95
approved these changes
Jan 11, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 11, 2022
Nothing special happens when converting to and from these constants, and its API is found to be more concise yet ever so slightly (0.1s) faster to compile than having separate `to_raw` and `from_raw` functions for each, that it makes sense to drop these entirely. Ash is still on a nonbreaking contribution streak so these functions are marked `deprecated` for now and will be removed at the next breaking crate release. [1]: #549 (comment)
MarijnS95
added a commit
that referenced
this pull request
Jan 11, 2022
Nothing special happens when converting to and from these constants, and its API is found to be more concise yet ever so slightly (0.1s) faster to compile than having separate `to_raw` and `from_raw` functions for each, that it makes sense to drop these entirely. Ash is still on a nonbreaking contribution streak so these functions are marked `deprecated` for now and will be removed at the next breaking crate release. [1]: #549 (comment)
MarijnS95
added a commit
that referenced
this pull request
Jan 11, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
Nothing special happens when converting to and from these constants, and its API is found to be more concise yet ever so slightly (0.1s) faster to compile than having separate `to_raw` and `from_raw` functions for each, that it makes sense to drop these entirely. Ash is still on a nonbreaking contribution streak so these functions are marked `deprecated` for now and will be removed at the next breaking crate release. [1]: #549 (comment)
MarijnS95
added a commit
that referenced
this pull request
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #546
So that vk_bitflags may be used directly in const contexts more ergonomically, similar to bitflags: https://docs.rs/bitflags/1.3.2/bitflags/example_generated/struct.Flags.html