Emit warnings when row limits are reached

[astrofrog]

For instance, the following should emit a warning:

from astropy.io import fits
table = Irsa.query_region("m42", catalog="fp_psc", spatial="Cone",
                          radius=10 * u.arcmin)

I spent a while figuring out why a patch of sky was missing, and then realized the row limit was quite low (500)

cc @Cadair

[keflavich]

👍 this is a good idea, as I've run into the same issues myself.

[bsipocz]

If this only an issue for irsa or something more central we need to implement for the whole of astroquery?

[Gabriel-p]

I'm querying the Irsa fp_psc catalog and I can't find where the row limit should be increased. Is it mentioned in the docs and I'm just missing it? Is it just not possible? I need the entire region to cross match with another catalog.

Sorry, found it Irsa.ROW_LIMIT = 10000.

[keflavich]

@Gabriel-p I'm glad you solved it. Yes, we need to improve the documentation (and warnings) here!

[Gabriel-p]

This made me wonder, why isn't this a standard argument of Irsa.query_region? Is there a reason for this or just something that was never updated?

[keflavich]

We implemented ROW_LIMIT as a configurable attribute globally rather than a query parameter. Perhaps it was not the right choice, but it is at least consistent (and configurable) across all services that support it.