Allow setting row limits in Gaia queries #1641
Merged
+66
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
==========================================
- Coverage 63% 62.97% -0.03%
==========================================
Files 185 185
Lines 14983 14985 +2
==========================================
- Hits 9440 9437 -3
- Misses 5543 5548 +5
Continue to review full report at Codecov.
|
bsipocz
approved these changes
Feb 14, 2020
| j = Gaia.cone_search_async(coord, radius) | ||
| r = j.get_results() | ||
|
|
||
| assert len(r) == 1188 |
There was a problem hiding this comment.
I suppose these values will change with new DRs, but let's cross that bridge when we get there.
|
Thanks @nmearl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to set the
ROW_LIMITclass attribute on the Gaia instance in order to limit the number of rows selected in the submitted query.