Implementation of LegacySurvey

[burnout87]

No description provided.

[pep8speaks]

Hello @burnout87! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file astroquery/legacysurvey/core.py:

Line 129:9: E265 block comment should start with '# '
Line 141:1: W293 blank line contains whitespace
Line 376:1: W293 blank line contains whitespace

• In the file astroquery/legacysurvey/tests/test_module.py:

Line 2:4: W292 no newline at end of file

• In the file astroquery/legacysurvey/tests/test_module_remote.py:

Line 21:76: E261 at least two spaces before inline comment
Line 68:86: E261 at least two spaces before inline comment

Comment last updated at 2021-11-15 10:37:15 UTC

[keflavich]

Thanks for the contribution!

A quick request: please call this something other than 'legacy survey' - perhaps DESILegacySurvey - since many observatories and instruments have legacy surveys.

[bsipocz]

@burnout87 - thank you for the PR. Before we proceed I would suggest to close this one and open another one from a branch rather than from your default master branch, as it will make it easier for you to pull newer changes onto your default branch while this PR is open.

Basically, all you need:

git checkout -b <name_of_feature_branch>
git push <your_forks_name> <name_of_feature_branch>

And then open a PR from your <name_of_feature_branch>.

Otherwise, I would share the comment of Adam above that we'll need to rethink the name and structure of the module. E.g. I am thinking along a line of a module of astroquery.desi and then DESILegacySurvey as the class? That would both leave space for other DESI surveys, as well as being unambiguous of which LegacySurvey it's about.

[burnout87]

Hi @bsipocz thanks for your comment. I will proceed as you suggested.