Skip to content

JIT: optimize out calls to term compare #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

JIT: optimize out calls to term compare #1833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 36 additions & 15 deletions libs/jit/src/jit.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,16 +528,26 @@ first_pass(<<?OP_IS_EQ_EXACT, Rest0/binary>>, MMod, MSt0, State0) ->
{MSt1, Arg1, Rest2} = decode_compact_term(Rest1, MMod, MSt0, State0),
{MSt2, Arg2, Rest3} = decode_compact_term(Rest2, MMod, MSt1, State0),
?TRACE("OP_IS_EQ_EXACT ~p, ~p, ~p\n", [Label, Arg1, Arg2]),
{MSt3, ResultReg} = MMod:call_primitive(MSt2, ?PRIM_TERM_COMPARE, [
ctx, jit_state, {free, Arg1}, {free, Arg2}, ?TERM_COMPARE_EXACT
]),
MSt4 = handle_error_if({'(int)', ResultReg, '==', ?TERM_COMPARE_MEMORY_ALLOC_FAIL}, MMod, MSt3),
MSt5 = cond_jump_to_label(
{{free, ResultReg}, '&', ?TERM_LESS_THAN + ?TERM_GREATER_THAN, '!=', 0},
Label,
MMod,
MSt4
),
% If Arg2 is an immediate, we don't need to call term_compare
MSt5 =
if
is_integer(Arg2) ->
{MSt3, Arg1Reg} = MMod:move_to_native_register(MSt2, Arg1),
cond_jump_to_label({{free, Arg1Reg}, '!=', Arg2}, Label, MMod, MSt3);
true ->
{MSt3, ResultReg} = MMod:call_primitive(MSt2, ?PRIM_TERM_COMPARE, [
ctx, jit_state, {free, Arg1}, {free, Arg2}, ?TERM_COMPARE_EXACT
]),
MSt4 = handle_error_if(
{'(int)', ResultReg, '==', ?TERM_COMPARE_MEMORY_ALLOC_FAIL}, MMod, MSt3
),
cond_jump_to_label(
{{free, ResultReg}, '&', ?TERM_LESS_THAN + ?TERM_GREATER_THAN, '!=', 0},
Label,
MMod,
MSt4
)
end,
?ASSERT_ALL_NATIVE_FREE(MSt5),
first_pass(Rest3, MMod, MSt5, State0);
% 44
Expand All @@ -547,11 +557,22 @@ first_pass(<<?OP_IS_NOT_EQ_EXACT, Rest0/binary>>, MMod, MSt0, State0) ->
{MSt1, Arg1, Rest2} = decode_compact_term(Rest1, MMod, MSt0, State0),
{MSt2, Arg2, Rest3} = decode_compact_term(Rest2, MMod, MSt1, State0),
?TRACE("OP_IS_NOT_EQ_EXACT ~p, ~p, ~p\n", [Label, Arg1, Arg2]),
{MSt3, ResultReg} = MMod:call_primitive(MSt2, ?PRIM_TERM_COMPARE, [
ctx, jit_state, {free, Arg1}, {free, Arg2}, ?TERM_COMPARE_EXACT
]),
MSt4 = handle_error_if({'(int)', ResultReg, '==', ?TERM_COMPARE_MEMORY_ALLOC_FAIL}, MMod, MSt3),
MSt5 = cond_jump_to_label({'(int)', {free, ResultReg}, '==', ?TERM_EQUALS}, Label, MMod, MSt4),
MSt5 =
if
is_integer(Arg2) ->
{MSt3, Arg1Reg} = MMod:move_to_native_register(MSt2, Arg1),
cond_jump_to_label({{free, Arg1Reg}, '==', Arg2}, Label, MMod, MSt3);
true ->
{MSt3, ResultReg} = MMod:call_primitive(MSt2, ?PRIM_TERM_COMPARE, [
ctx, jit_state, {free, Arg1}, {free, Arg2}, ?TERM_COMPARE_EXACT
]),
MSt4 = handle_error_if(
{'(int)', ResultReg, '==', ?TERM_COMPARE_MEMORY_ALLOC_FAIL}, MMod, MSt3
),
cond_jump_to_label(
{'(int)', {free, ResultReg}, '==', ?TERM_EQUALS}, Label, MMod, MSt4
)
end,
?ASSERT_ALL_NATIVE_FREE(MSt5),
first_pass(Rest3, MMod, MSt5, State0);
% 45
Expand Down
Loading