Add example for gleam_otp static_supervisor and actor #1984
Conversation
- gleam_otp uses proc_lib module for spawning actors and since this module is recently added to AtomVM it is possible now to use this. - The example is using asserts so it can be added to CI later. Signed-off-by: Mikael Karlsson <[email protected]>
Signed-off-by: Mikael Karlsson <[email protected]>
Signed-off-by: Mikael Karlsson <[email protected]>
Signed-off-by: Mikael Karlsson <[email protected]>
Signed-off-by: Mikael Karlsson <[email protected]>
bettio
left a comment
bettio
left a comment
There was a problem hiding this comment.
Everything looks good now, thank you. Before we merge, could you please rebase to tidy up the commit history? For example, the Correct author in copyright notice commit could be squashed into Add example for gleam_otp static_supervisor and actor.
It’s fine to keep more than one commit, but in general I try to avoid adding fixup commits for changes introduced within the same PR.
|
Opps sorry, I resolved to early. |
|
OK, sorry for the mess, I squashed all my commits into one new rebased PR #1987. With one commit. |
Add example for gleam_otp static_supervisor and actor Supersedes #1984
|
Overridden by #1987 which is merged. Closing this one. |
3 participants
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later
There is (currently commented out) code for testing the supervisor one_for_all strategy once PR #1958 is merged.