merge sessionChanges before finalizing session after refresh #2401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
The
beforeSessionSavedhook should be called with the updated session after the tokenSet has been refreshed. A recent change in this PR fixed the behavior when requesting the access token via the token route. Thanks again for having responded to my issue so promptly.One case remains though where the old, buggy behavior remains: when
getAccessTokenis been called server side like it would be in next middleware. This PR fixes the issue in the same way the issue has been fixed elsewhere.📎 References
related PR: fix: make sure beforeSessionSaved hook gets the updated token after refresh
initial issue: beforeSessionSaved behaves differently when called after login or after token refresh
🎯 Testing
Unit tests included with the PR