e2e: Add local network fixture #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2023
marun
force-pushed
the
e2e-local-network
branch
4 times, most recently
from
a29c191 to
6ad4e71
Compare
dasconnor
reviewed
Jul 10, 2023
Contributor
dasconnor
left a comment
dasconnor
left a comment
There was a problem hiding this comment.
The design looks good.
I will mention though that this is pretty similar to functionality we offer in the avalanche-cli test suite. With one or two small tweaks, you could replicate this functionality using ANR/CLI. The one feature we'd need to change is enabling a custom avalanchego instance. Currently we only support official releases.
An example suite: https://github.com/ava-labs/avalanche-cli/blob/main/tests/e2e/testcases/subnet/local/suite.go
Contributor
Author
|
Rebased |
hexfusion
reviewed
Jul 11, 2023
Contributor
hexfusion
left a comment
hexfusion
left a comment
There was a problem hiding this comment.
Looking great on first pass!
hexfusion
reviewed
Jul 11, 2023
marun
force-pushed
the
e2e-local-network
branch
13 times, most recently
from
17907a7 to
30e0b72
Compare
Previously this was only used for dynamic port usage, but it's faster for static ports to use this strategy too.
It will still be possible to set static ports by supplying explicit node configuration.
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: marun <[email protected]>
marun
force-pushed
the
e2e-local-network
branch
from
2f10243 to
643ce4b
Compare
StephenButtolph
approved these changes
Aug 8, 2023
darioush
reviewed
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
To better enable e2e test development, this PR adds a new orchestration mechanism for local test networks. Nodes are launched as independent processes and all configuration is serialized to disk to avoid requiring a persistent rpc daemon. Evolving requirements can be implemented directly in the avalanchego repo.
A new CI job (
test_e2e_persistent) is added in this PR to start and stop a network with the new fixture. #1709 switches e2e to use the new fixture and updates the new job to run e2e against a persistent network.How this works
Preliminary documentation has been added via fixture README.
How this was tested
TODO