fix: block hash when overriding to block n+1 #1301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
approved these changes
Sep 30, 2025
Collaborator
ceyonur
left a comment
ceyonur
left a comment
There was a problem hiding this comment.
overall lgtm, just a nit that could reduce the diff between ethereum/go-ethereum#32183
powerslider
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Addresses ethereum/go-ethereum#32175 in which the
BLOCKHASHop code returns0x00when simulating a transaction at blockHEAD+1.How this works
Sets the parent block hash based on code from ethereum/go-ethereum#32183. A cherry-pick wasn't viable due to conflicts.
How this was tested
UT from the above PR, which failed before adding the fix.
Need to be documented?
Yes
Need to update RELEASES.md?
Yes