This repository was archived by the owner on Apr 4, 2023. It is now read-only.
*: make code compilable #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
quarkvm/tx_heap.go
Outdated
| return has | ||
| } | ||
|
|
||
| var _ memPool = &txHeap{} |
There was a problem hiding this comment.
nit: mempool not memPool
quarkvm/vm.go
Outdated
| // Get the value to put in the new block | ||
| value := vm.mempool[0] | ||
| vm.mempool = vm.mempool[1:] | ||
| maxTx, _ := vm.memPool.popMax() |
There was a problem hiding this comment.
Probably want to put a todo here to iterate over txs in pool until tx can't pay more fees: https://github.com/ava-labs/simple-kvvm/blob/86a8737bd9af24f88a838dabefd6877bc6190043/chain/chain.go#L178-L198
There was a problem hiding this comment.
(more than just single tx addition)
quarkvm/vm.go
Outdated
| // (namely, a block with data [data]) | ||
| func (vm *VM) proposeBlock(data [dataLen]byte) { | ||
| vm.mempool = append(vm.mempool, data) | ||
| vm.memPool.push(newTransaction(ids.Empty)) |
There was a problem hiding this comment.
nit: proposing a block won't be possible anymore, we'll instead use a block-based timer: https://github.com/ava-labs/coreth/blob/master/plugin/evm/block_builder.go
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some readme updates. More changes to follow.