This repository was archived by the owner on Apr 4, 2023. It is now read-only.
[AV-1087] vm: use LRU for block cache #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
changed the title
vm/chain_vm.go
Outdated
| } | ||
|
|
||
| func (vm *VM) Accepted(b *chain.StatelessBlock) { | ||
| // still keep in LRU cache for following "getBlock" calls |
There was a problem hiding this comment.
You may need to change the status of the block in memory if you are going to use the cached version later.
There was a problem hiding this comment.
Otherwise, it may still say processing, etc.
| // manually delete | ||
| delete(vm.verifiedBlocks, blkID) | ||
|
|
||
| blk2, err := vm.getBlock(blkID) |
There was a problem hiding this comment.
You should add a case that the values are correct after Accept when fetching from the cache.
There was a problem hiding this comment.
This should be checked via
if !reflect.DeepEqual(blk, blk2) {
t.Fatalf("block expected %+v, got %+v", blk, blk2)
}?
Checks all status + heights... etc.
Signed-off-by: Gyuho Lee <[email protected]>
patrick-ogrady
approved these changes
Dec 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache for each "Verified" call and evict on "Reject". To optimize
VM.lookbackcalls.