This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Block Value Reuse #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Jan 11, 2022
|
|
||
| func GetBlock(db database.KeyValueReader, bid ids.ID) ([]byte, error) { | ||
| return db.Get(PrefixBlockKey(bid)) | ||
| func GetBlock(db database.KeyValueReader, bid ids.ID) (*StatefulBlock, []byte, error) { |
gyuho
reviewed
Jan 11, 2022
| Preferred() (ids.ID, error) | ||
| // Checks the validity of the block. | ||
| // Accepted fetches the ID of the last accepted block. | ||
| Accepted() (ids.ID, error) |
There was a problem hiding this comment.
This is actually a usage improvement as well...if you build off the preferred, the blockID you are referencing may get orphaned and you'll need to start over.
gyuho
reviewed
Jan 11, 2022
| kvs = append(kvs, KeyValue{ | ||
| Key: formattedKey, | ||
| Value: cursor.Value(), | ||
| Value: v, |
There was a problem hiding this comment.
Does this mean now we can return same k-v pairs but with different tx IDs? Should we incude tx id in the response?
There was a problem hiding this comment.
I guess we could return it now that we have it in case people want to know when it was last updated?
There was a problem hiding this comment.
I think we can do this in another PR, however. This is complex enough.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #31
closes: #36