This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Remove POW [Part 1] #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
reviewed
Jan 13, 2022
|
|
||
| func (l *LifelineTx) Execute(g *Genesis, db database.Database, blockTime uint64, _ ids.ID) error { | ||
| return addLife(g, db, l.Prefix, g.LifelineUnitReward*l.Units) | ||
| func (l *LifelineTx) Execute(t *TransactionContext) error { |
There was a problem hiding this comment.
+100, now much nicer to package them in a single TransactionContext
gyuho
reviewed
Jan 13, 2022
|
|
||
| package chain | ||
|
|
||
| import "github.com/ava-labs/avalanchego/utils/crypto" |
gyuho
reviewed
Jan 13, 2022
| } | ||
| } | ||
|
|
||
| // compute new min difficulty |
There was a problem hiding this comment.
fix this comment? and can we also document how we decide the pricing
gyuho
reviewed
Jan 13, 2022
| pDiff = g.MinDifficulty | ||
| // Sort useful costs/prices | ||
| sort.Slice(ctx.Prices, func(i, j int) bool { return ctx.Prices[i] < ctx.Prices[j] }) | ||
| pPrice := ctx.Prices[(len(ctx.Prices)-1)*feePercentile/100] |
There was a problem hiding this comment.
Forgot to ask about feePercentile in previous PR. How did we come up with the number 60?
patrick-ogrady
force-pushed
the
remove-pow
branch
from
0ecc8c8 to
058d09f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.