Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

ParseBlock Invariant Fix #89

Merged
merged 3 commits into from
Jan 20, 2022
Merged

ParseBlock Invariant Fix #89

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d698c0
invariant fix
patrick-ogrady Jan 20, 2022
2c553de
nits
patrick-ogrady Jan 20, 2022
e81fbd1
add more logs
patrick-ogrady Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions vm/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,17 +340,25 @@ func (vm *VM) GetStatelessBlock(blkID ids.ID) (*chain.StatelessBlock, error) {
// implements "snowmanblock.ChainVM.commom.VM.Parser"
// replaces "core.SnowmanVM.ParseBlock"
func (vm *VM) ParseBlock(source []byte) (snowman.Block, error) {
blk, err := chain.ParseBlock(
newBlk, err := chain.ParseBlock(
source,
choices.Processing,
vm,
)
if err != nil {
log.Error("could not parse block", "err", err)
} else {
log.Debug("parsed block", "id", blk.ID())
return nil, err
}
return blk, err
log.Debug("parsed block", "id", newBlk.ID())

// If we have seen this block before, return it with the most
// up-to-date info
if oldBlk, err := vm.GetBlock(newBlk.ID()); err == nil {
log.Debug("returning previously parsed block", "id", oldBlk.ID())
return oldBlk, nil
}

return newBlk, nil
}

// implements "snowmanblock.ChainVM"
Expand Down