-
Notifications
You must be signed in to change notification settings - Fork 274
use Kurtosis instead of the run script #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f004dd4
use Kurtosis to spin up nodes instead of script
h4ck3rk3y 250317a
cleanup ci
h4ck3rk3y f4d2b99
added new line
h4ck3rk3y 571b1f2
use start instead of restart
h4ck3rk3y c133539
error is the last thing to be returned
h4ck3rk3y 11450f2
fixed framing of KT job
h4ck3rk3y a24ee17
Update tests/utils/node_launcher.go
h4ck3rk3y 2b2bc20
propagate various error types
h4ck3rk3y 2d86c0d
use the single error abstraction
h4ck3rk3y 74a1dea
pin 0.77.0
h4ck3rk3y 29c6cb4
ran go mod tidy
h4ck3rk3y 255b8d7
try running after building image instead
h4ck3rk3y c9de7fb
fix arguments
h4ck3rk3y c77873f
fix json
h4ck3rk3y 14d5bc0
fix json for real
h4ck3rk3y 86d6da8
correctly populate node id
h4ck3rk3y 34338c7
actually correctly populate node id
h4ck3rk3y 2741b09
this should work
h4ck3rk3y d0dac57
test out multi node behavior
h4ck3rk3y 71f1c3d
added note about cli installation
h4ck3rk3y 20a64ab
fix node count argument
h4ck3rk3y 19478f7
use a constant instead
h4ck3rk3y 406f885
use the right parameter for image passing
h4ck3rk3y ebf8ee4
propagate tear down errors
h4ck3rk3y 89ab874
Add notes about test docker image
h4ck3rk3y 5eda8ed
test health of every node in multi node test
h4ck3rk3y 269ec3c
revert load test to single node due to flake
h4ck3rk3y de07e1f
Update run_ginkgo.sh
h4ck3rk3y a9824c2
Update node_launcher.go
h4ck3rk3y File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this comes with new requirements (install kurtosis cli), would it be possible to add or link instructions that are necessary to run the e2e tests with this change?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added instructions about installing Kurtosis & restarting the engine. Let me know what you think and if there's a better spot to put this apart from this script.