Skip to content

Conversation

@PG-practice
Copy link

@PG-practice PG-practice commented Sep 24, 2024

Problem

Issue number, if available:
#825

Changes

  1. Add top level error handling with reference to similar fix top-level error handling #865
    In top-level error handling #865, parser and usageDataEmitter appears to be used for subcommands (e.g. ampx sandbox), so omit these parameters because create-amplify command are not followed by subcommands

Corresponding docs PR, if applicable:

Validation

  • error_handler.ts and it's test cases are based on a similar issue fix top-level error handling #865
  • Pressing Ctrl + C during Where should we create your project? prompt causes no error.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@PG-practice PG-practice requested a review from a team as a code owner September 24, 2024 03:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: 38ca68e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant