Skip to content

Conversation

dpilch
Copy link

@dpilch dpilch commented Nov 29, 2022

Description of changes

See #513 for similar test for TypeScript apps.

Issue #, if available

PR to introduce the error: #489

PR to fix the error: #500

Description of how you validated changes

Run on CircleCI

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 1 alert when merging e5e106c into 0cdc527 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

❗ No coverage uploaded for pull request base (upgrade-graphql-15@ec0e433). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             upgrade-graphql-15     #520   +/-   ##
=====================================================
  Coverage                      ?   85.50%           
=====================================================
  Files                         ?      148           
  Lines                         ?     7269           
  Branches                      ?     1913           
=====================================================
  Hits                          ?     6215           
  Misses                        ?      958           
  Partials                      ?       96           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 1 alert when merging 183059a into 0cdc527 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 1 alert when merging 0db3dc1 into 0cdc527 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 29, 2022

This pull request introduces 1 alert when merging d8f6263 into 0cdc527 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@dpilch dpilch mentioned this pull request Dec 2, 2022
6 tasks
@dpilch dpilch changed the base branch from main to upgrade-graphql-15 December 2, 2022 22:10
@dpilch dpilch changed the title ci: build add e2e test for swift ci: add build e2e test for swift Dec 5, 2022
import { existsSync, writeFileSync, readdirSync, rmSync, readFileSync } from 'fs';
import path from 'path';

const skip = new Set([
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cases are consistently failing. This indicates an existing issue with codegen for these cases.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cases are not supported currently. They all involve cyclical references to models. This change (#504) will add support.

@dpilch dpilch marked this pull request as ready for review December 5, 2022 21:21
@dpilch dpilch requested a review from a team as a code owner December 5, 2022 21:21
@dpilch dpilch marked this pull request as draft December 27, 2022 15:37
@dpilch dpilch force-pushed the upgrade-graphql-15 branch 2 times, most recently from 07fc1e2 to 37460d3 Compare January 11, 2023 20:22
@dpilch dpilch marked this pull request as ready for review January 24, 2023 20:21
@dpilch dpilch changed the base branch from upgrade-graphql-15 to main January 24, 2023 21:27
- run: yarn config set workspaces-experimental true
- run: yarn cache clean --force
- run: yarn run production-build
- run: CXXFLAGS="--std=c++17" yarn run production-build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this for all runs?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set it for only the mac executor now.

Copy link
Contributor

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dpilch dpilch merged commit 64e1ee6 into main Jan 30, 2023
@dpilch dpilch deleted the swift-test-app branch January 30, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants