-
Notifications
You must be signed in to change notification settings - Fork 62
ci: add build e2e test for swift #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request introduces 1 alert when merging e5e106c into 0cdc527 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Codecov Report
@@ Coverage Diff @@
## upgrade-graphql-15 #520 +/- ##
=====================================================
Coverage ? 85.50%
=====================================================
Files ? 148
Lines ? 7269
Branches ? 1913
=====================================================
Hits ? 6215
Misses ? 958
Partials ? 96 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This pull request introduces 1 alert when merging 183059a into 0cdc527 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging 0db3dc1 into 0cdc527 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
This pull request introduces 1 alert when merging d8f6263 into 0cdc527 - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
0b912e3
to
146cc18
Compare
f1d8192
to
75d1f34
Compare
import { existsSync, writeFileSync, readdirSync, rmSync, readFileSync } from 'fs'; | ||
import path from 'path'; | ||
|
||
const skip = new Set([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cases are consistently failing. This indicates an existing issue with codegen for these cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These cases are not supported currently. They all involve cyclical references to models. This change (#504) will add support.
07fc1e2
to
37460d3
Compare
4166cce
to
bcd6c3f
Compare
bcd6c3f
to
c3f90cc
Compare
.circleci/config.base.yml
Outdated
- run: yarn config set workspaces-experimental true | ||
- run: yarn cache clean --force | ||
- run: yarn run production-build | ||
- run: CXXFLAGS="--std=c++17" yarn run production-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this for all runs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set it for only the mac executor now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description of changes
See #513 for similar test for TypeScript apps.
Issue #, if available
PR to introduce the error: #489
PR to fix the error: #500
Description of how you validated changes
Run on CircleCI
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.