feat(rtn-web-browser): add unit tests #14541
Open
+551
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedhamouda78
requested review from
Amplifiyer,
avi-karthik and
pranavosu
as code owners
soberm
previously approved these changes
Sep 3, 2025
packages/rtn-web-browser/__tests__/apis/openAuthSessionAsync.test.ts
Outdated
Show resolved
Hide resolved
soberm
previously approved these changes
Sep 3, 2025
6 tasks
bobbor
reviewed
Sep 8, 2025
| expect.any(Function), | ||
| ); | ||
| expect(result).toBeNull(); | ||
| }, 10000); |
There was a problem hiding this comment.
these timeouts seem rather high.
do you know what part is taking so much time that an increase in timeout is required?
maybe this can be resolved with mocking dependencies.
There was a problem hiding this comment.
I removed the timeouts entirely as the tests pass just fine without them. This was just an artifact from development that I forgot about.
ahmedhamouda78
force-pushed
the
feat/rtn-web-browser-unit-tests
branch
from
9509307 to
2aae6a6
Compare
pranavosu
previously approved these changes
Sep 24, 2025
ahmedhamouda78
force-pushed
the
feat/rtn-web-browser-unit-tests
branch
from
61f6777 to
2272e47
Compare
Simone319
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds comprehensive unit tests for the
@aws-amplify/rtn-web-browserpackage to achieve 100% test coverage.Issue #, if available
N/A
Description of how you validated changes
yarn testChecklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.