test(datastore): Lazy loading integration tests #2448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2022
lawmicha
force-pushed
the
lawmicha.lazymodel2
branch
from
d621f0f to
69b5b0b
Compare
lawmicha
force-pushed
the
lawmicha.lazymodel.codegen
branch
6 times, most recently
from
79c51a2 to
252a5d4
Compare
lawmicha
commented
Oct 19, 2022
Comment on lines
+138
to
+141
| if let id = modelValue as? String, | ||
| (field.name == ModelIdentifierFormat.Custom.sqlColumnName || // this is the `@@primaryKey` (CPK) | ||
| (schema.primaryKey.fields.count == 1 // or there's only one primary key (not composite key) | ||
| && schema.primaryKey.indexOfField(named: field.name) != nil)) { // and this field is the primary key |
There was a problem hiding this comment.
bug where lazy List was not being created due to field.primaryKey of the generated code was not returning true for Post4V2. this change can be applied directly on main and cherry picked over to v1.
lawmicha
commented
Oct 19, 2022
Comment on lines
+62
to
+63
| } else if case .collection = modelField.type { // skip all "has-many" | ||
| continue |
There was a problem hiding this comment.
bug where collections's are being set to nil in the GraphQL input, so for example, when creating a Post and saving it through DataStore. the sync process will translate the post to the GraphQL input variables containing
{
"id": "postid123",
"comments": null
}
The problem is this fails as there's no input type "comments". We should skip has-many relationships like in this code snippet. This can be done in main and v1
lawmicha
force-pushed
the
lawmicha.lazymodel.codegen
branch
from
3109798 to
b26516a
Compare
…n update, removal association on update) - allow updates from a model with not loaded lazy model. the identifier gets extracted out from the not loaded state and persisted in SQL. eager load on save continues to get the loaded model back for the sync to AppSync - ModelDecorator on update mutations will add `nil` for the targetName fields because updates may remove associations from models. - allow lazy model to be decoded as a notLoaded state with empty identifier. this is when there is no data to load in the associated data, and simply is not set yet. for example creating a comment and saving it, without a post attached. this is for optional associations - update some of the codegenerated types to allow setting a `nil` value to represent the removal use case. - start adding some many-to-many tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Table of Contents:
Description of changes:
This PR consists of the integration tests against a live backend using the expected codegenerated models for a variety of schemas being tested.
DataStore.save API will persist the data using the SQL adapter, then query for the data. The queried data as part of the save API call will continue to be eager loaded as the model is needed for syncing to the cloud. If the data is lazy loaded, then there's a problem model only containing the SQL identifier information
@@primaryKeycolumn value. We might be able to allow lazy loading on the save data flow with some more changes to the implementation.DataStore.query API will allow lazy loading of SQL data
Check points: (check or cross out if not relevant)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.