Skip to content

Conversation

@lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 7, 2023

Issue #

Description

We recently added this change #2734 expecting codegen to generate has-one with associatedFields in aws-amplify/amplify-codegen#541. We were working through some implementation details in #2737 that no longer depends on has-one to have associatedFields. This change is to revert it until we identify an actual need to move forward with the codegen changes.

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested a review from a team as a code owner February 7, 2023 20:55
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #2750 (51b3e10) into v1 (9ce0c58) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##               v1    #2750      +/-   ##
==========================================
- Coverage   64.37%   64.29%   -0.09%     
==========================================
  Files         720      720              
  Lines       22742    22732      -10     
==========================================
- Hits        14641    14616      -25     
- Misses       8101     8116      +15     
Flag Coverage Δ
API_plugin_unit_test 66.78% <ø> (ø)
AWSPluginsCore 73.34% <100.00%> (ø)
Amplify 51.31% <100.00%> (+0.04%) ⬆️
Analytics_plugin_unit_test 72.43% <ø> (ø)
Auth_plugin_unit_test 83.80% <ø> (ø)
DataStore_plugin_unit_test 81.65% <100.00%> (-0.36%) ⬇️
Geo_plugin_unit_test 57.87% <ø> (ø)
Predictions_plugin_unit_test 33.61% <ø> (ø)
Storage_plugin_unit_test 59.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Model/Internal/Schema/ModelSchema+Definition.swift 58.82% <ø> (+2.92%) ⬆️
...Model/Internal/Schema/ModelField+Association.swift 45.83% <100.00%> (-1.11%) ⬇️
...e/AWSPluginsCore/Model/Support/Model+GraphQL.swift 74.80% <100.00%> (ø)
...insCore/Model/Support/QueryPredicate+GraphQL.swift 74.63% <100.00%> (ø)
...goryPlugin/Storage/SQLite/ModelSchema+SQLite.swift 94.25% <100.00%> (ø)
...ingMutationQueue/OutgoingMutationQueue+State.swift 0.00% <0.00%> (-68.75%) ⬇️
...ngMutationQueue/OutgoingMutationQueue+Action.swift 0.00% <0.00%> (-66.67%) ⬇️
...MutationQueue/OutgoingMutationQueue+Resolver.swift 82.14% <0.00%> (-10.72%) ⬇️
Amplify/Categories/Hub/HubFilter.swift 52.63% <0.00%> (-5.27%) ⬇️
...s/AWSHubPlugin/Internal/HubChannelDispatcher.swift 94.11% <0.00%> (-2.95%) ⬇️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@5d 5d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lawmicha lawmicha merged commit f575243 into v1 Feb 7, 2023
@lawmicha lawmicha deleted the v1.fix-remove-has-one-associatedFields branch February 7, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants