Skip to content

Conversation

@lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 7, 2023

Issue #

Description

Enable DataStore and API's lazy loading test targets

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha requested review from a team as code owners February 7, 2023 22:16
Copy link
Contributor

@5d 5d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lawmicha lawmicha merged commit 98e7795 into data-dev-preview Feb 7, 2023
@lawmicha lawmicha deleted the data-dev-preview.chore branch February 7, 2023 23:12
lawmicha added a commit that referenced this pull request Feb 8, 2023
lawmicha added a commit that referenced this pull request Feb 8, 2023
harsh62 pushed a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants