Skip to content

Conversation

@lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Feb 8, 2023

Issue #

Description

While going over previous integration tests, specifically DataStoreTransformerV2 tests. One of the tests was failing because we were trying to send nil values of the foreign key for create mutations. We shouldn't be sending a create mutation, but rather an update mutation on an existing model. updateMutations will set nil values for the FK to act as an removal of an assocation. The implementation change was introduced in #2701 to data-dev-preview and this test was not run to catch the failure

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha merged commit ccc7a3c into data-dev-preview Feb 8, 2023
@lawmicha lawmicha deleted the data-dev-preview.fix-transformer-v2-test branch February 8, 2023 00:34
lawmicha added a commit that referenced this pull request Feb 8, 2023
lawmicha added a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants