Skip to content

Conversation

cwomack
Copy link
Member

@cwomack cwomack commented Apr 26, 2023

Description of changes:

Updates to the Angular Getting Started tutorial, specifically the Connect API and database to the app where improper file references were made and an outdated GraphQL schema is used (GraphQL API operates on a "deny-by-default" principle if an authorization rule is not specifically configured).

This removes errors experienced when running through the tutorial, even AFTER the auth category is implemented.

Related GitHub issue #, if available:

Resolves #4743

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • iOS
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://link.com)
    HTML: <a href="https://link.com">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

cwomack and others added 30 commits March 8, 2023 06:04
…of scope for this PR, saving for Analytics updates overall).
…om PR Reviews, and added of existing AWS resource links.
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwomack cwomack changed the title fix(JS): Update Angular Getting Started guides with proper schema and file references fix(JS): Update Angular Getting Started tutorial with proper schema and file references Apr 26, 2023
@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-5433.d39agkzf0cwtdz.amplifyapp.com

@cwomack cwomack marked this pull request as ready for review April 26, 2023 20:13
@cwomack cwomack requested a review from a team as a code owner April 26, 2023 20:13
@katieklein katieklein requested a review from a team April 26, 2023 20:26
cshfang
cshfang previously approved these changes May 5, 2023
stocaaro
stocaaro previously approved these changes May 8, 2023
@abdallahshaban557 abdallahshaban557 added the ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge label May 8, 2023
katieklein
katieklein previously approved these changes May 9, 2023
@katieklein katieklein dismissed stale reviews from stocaaro, cshfang, abdallahshaban557, and themself via d4569c7 May 9, 2023 16:56
@katieklein katieklein merged commit ff12f5c into aws-amplify:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amplify/js Issues tied to JS ready-to-merge all approvals are in and this PR is ready for a docs engineer to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Connect API and database to the app" part

5 participants