-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(JS): Update Angular Getting Started tutorial with proper schema and file references #5433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing authentication
…of scope for this PR, saving for Analytics updates overall).
…l PR feedback implemented.
…k for Flutter & mobile.
…om PR Reviews, and added of existing AWS resource links.
…iles that were already merged in #5219
…ct-native.mdx Co-authored-by: David McAfee <[email protected]>
…lock should look like for restaurants.component.ts
abdallahshaban557
previously approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request is automatically being deployed by Amplify Hosting (learn more). |
cshfang
previously approved these changes
May 5, 2023
stocaaro
previously approved these changes
May 8, 2023
katieklein
previously approved these changes
May 9, 2023
d4569c7
cshfang
approved these changes
May 9, 2023
cshfang
approved these changes
May 9, 2023
abdallahshaban557
approved these changes
May 9, 2023
katieklein
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
amplify/js
Issues tied to JS
ready-to-merge
all approvals are in and this PR is ready for a docs engineer to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updates to the Angular Getting Started tutorial, specifically the Connect API and database to the app where improper file references were made and an outdated GraphQL schema is used (GraphQL API operates on a "deny-by-default" principle if an authorization rule is not specifically configured).
This removes errors experienced when running through the tutorial, even AFTER the auth category is implemented.
Related GitHub issue #, if available:
Resolves #4743
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://link.com)
HTML:
<a href="https://link.com">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.