generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 176
Closed
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedidempotencyThis item relates to the Idempotency UtilityThis item relates to the Idempotency UtilityinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change testsPRs that add or change tests
Description
Summary
After merging #2570 some of the integration tests related to the Idempotency utility are failing.
This is because some of the payloads used to seed the tests don't match the control idempotency key due to the former not being deep sorted.
This was raised during the review but I forgot to ask the contributor to include it before merging.
Why is this needed?
So that we can continue running integration tests.
Which area does this relate to?
Tests
Solution
We should make sure that all the payloads in the packages/idempotency/tests/e2e/makeIdempotent.test.ts
file are sorted.
Acknowledgment
- This request meets Powertools for AWS Lambda (TypeScript) Tenets
- Should this be considered in other Powertools for AWS Lambda languages? i.e. Python, Java, and .NET
Future readers
Please react with 👍 and your use case to help us understand customer demand.
Metadata
Metadata
Assignees
Labels
completedThis item is complete and has been merged/shippedThis item is complete and has been merged/shippedidempotencyThis item relates to the Idempotency UtilityThis item relates to the Idempotency UtilityinternalPRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)testsPRs that add or change testsPRs that add or change tests
Type
Projects
Status
Shipped