Skip to content

Conversation

@sthulb
Copy link
Contributor

@sthulb sthulb commented Nov 30, 2023

Description of your changes

Update layer canary logs to comply with AWS log retention policy

Related issues, RFCs

Issue number: #1808

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team November 30, 2023 10:52
@boring-cyborg boring-cyborg bot added the layers Items related to the Lambda Layers pipeline label Nov 30, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Nov 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sthulb sthulb merged commit eb1701f into main Nov 30, 2023
@sthulb sthulb deleted the chore/logs branch November 30, 2023 11:13
@dreamorosi dreamorosi linked an issue Dec 8, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

layers Items related to the Lambda Layers pipeline size/XS PR between 0-9 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Update log retention to 10 years as per policy

1 participant