Skip to content

Conversation

@yamatatsu
Copy link
Contributor

Description of your changes

Fixing some typos on docs.

Related issues, RFCs

I skipped creating a issue. 🙏

Issue number:

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@yamatatsu yamatatsu requested a review from a team December 20, 2023 01:20
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Dec 20, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Dec 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 20, 2023

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #typescript channel on our Powertools for AWS Lambda Discord: Invite link

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@am29d
Copy link
Contributor

am29d commented Dec 20, 2023

Hi @yamatatsu , ありがとうございます for the PR, really appreciate your eye to spot the errors!

I have checked the typos in my IDE and we have a lot more to fix. I have opened an issue #1825 so we can track them all. Would it be ok for you to go through all of them and fix it this PR?

Thank you for your contribution. 🙏

@am29d am29d requested review from am29d and removed request for a team December 20, 2023 05:47
Copy link
Contributor

@am29d am29d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1825 issue for additional typos we would like to catch with this PR

@dreamorosi dreamorosi linked an issue Dec 20, 2023 that may be closed by this pull request
1 task
@sthulb sthulb merged commit 1811ec8 into aws-powertools:main Dec 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 29, 2023

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@am29d am29d mentioned this pull request Jan 3, 2024
9 tasks
dreamorosi pushed a commit that referenced this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/XS PR between 0-9 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: fix typos

3 participants