Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Feb 14, 2024

Description of your changes

  • Add badges to readme

Related issues, RFCs

Issue number: #2045

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@hjgraca hjgraca requested a review from a team February 14, 2024 17:30
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Feb 14, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Feb 14, 2024
@hjgraca hjgraca changed the title chore(readme): include badges in readme chore(docs): include badges in readme Feb 14, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hjgraca thank you for the PR!

I left comments related to the "build" and "downloads" badges, which I think we should remove and potentially reconsider in a future PR if applicable.

@pull-request-size pull-request-size bot added size/XS PR between 0-9 LOC and removed size/S PR between 10-29 LOC labels Feb 15, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi self-requested a review February 15, 2024 11:30
@dreamorosi dreamorosi linked an issue Feb 15, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this PR and addressing all the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation This item relates to automation size/XS PR between 0-9 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: add badges to the main README

3 participants