Skip to content

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Apr 15, 2024

Description of your changes

This PR adds DeadLetterQueueSourceArn field to SQS message attributes.

Related issues, RFCs

Issue number: closes #2361

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested a review from a team April 15, 2024 12:29
@am29d am29d requested a review from a team as a code owner April 15, 2024 12:29
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Apr 15, 2024
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Apr 15, 2024
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly addressing this one.

Left a very minor comment.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit e2fcd9e into main Apr 15, 2024
@dreamorosi dreamorosi deleted the fix/2361-add-dlq-attribute branch April 15, 2024 13:09
@am29d am29d self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser This item relates to the Parser Utility size/XS PR between 0-9 LOC tests PRs that add or change tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: add DeadLetterQueueSourceArn on SqsAttributesModel

2 participants