Skip to content

fix(parser): set APIGatewayProxyEventSchema body and query string keys to be nullable #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2024
Merged

fix(parser): set APIGatewayProxyEventSchema body and query string keys to be nullable #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/parser/src/schemas/apigw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ const APIGatewayProxyEventSchema = z.object({
'OPTIONS',
]),
headers: z.record(z.string()).optional(),
queryStringParameters: z.record(z.string()).optional(),
queryStringParameters: z.record(z.string()).nullable(),
multiValueHeaders: z.record(z.array(z.string())).optional(),
multiValueQueryStringParameters: z.record(z.array(z.string())).optional(),
multiValueQueryStringParameters: z.record(z.array(z.string())).nullable(),
requestContext: APIGatewayEventRequestContext,
pathParameters: z.record(z.string()).optional().nullish(),
stageVariables: z.record(z.string()).optional().nullish(),
isBase64Encoded: z.boolean().optional(),
body: z.string().optional(),
body: z.string().nullable(),
});

export { APIGatewayProxyEventSchema, APIGatewayCert };
6 changes: 5 additions & 1 deletion packages/parser/tests/events/apiGatewayAuthorizerRequestEvent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
"queryStringParameters": {
"QueryString1": "queryValue1"
},
"multiValueQueryStringParameters": {
"QueryString1": ["queryValue1"]
},
"pathParameters": {},
"stageVariables": {
"StageVar1": "stageValue1"
Expand Down Expand Up @@ -64,5 +67,6 @@
"resourceId": "ANY /request",
"resourcePath": "/request",
"stage": "test"
}
},
"body": null
}
4 changes: 2 additions & 2 deletions packages/parser/tests/unit/envelopes/apigwt.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ describe('ApigwEnvelope ', () => {

it('should throw no body provided', () => {
const testEvent = TestEvents.apiGatewayProxyEvent as APIGatewayProxyEvent;
testEvent.body = undefined;
testEvent.body = null;

expect(() => ApiGatewayEnvelope.parse(testEvent, TestSchema)).toThrow(
ParseError
Expand Down Expand Up @@ -56,7 +56,7 @@ describe('ApigwEnvelope ', () => {

it('should return success false with original body if no body provided', () => {
const testEvent = TestEvents.apiGatewayProxyEvent as APIGatewayProxyEvent;
testEvent.body = undefined;
testEvent.body = null;

const resp = ApiGatewayEnvelope.safeParse(testEvent, TestSchema);
expect(resp).toEqual({
Expand Down