Skip to content

Conversation

dreamorosi
Copy link
Contributor

Summary

Changes

Please provide a summary of what's being changed

This PR switches the test runner of the jmespath package from Jest to Vitest, continuing the migration effort for the project.

The PR is small and focuses primarily in: 1/ changing the imports to vitest specific ones and 2/ updating the commands & configs to suit the new runner.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3078


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Sep 16, 2024
@boring-cyborg boring-cyborg bot added the dependencies Changes that touch dependencies, e.g. Dependabot, etc. label Sep 16, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Sep 16, 2024
@boring-cyborg boring-cyborg bot added automation This item relates to automation internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) labels Sep 16, 2024
Copy link

@dreamorosi dreamorosi marked this pull request as ready for review September 16, 2024 22:04
@dreamorosi dreamorosi requested a review from a team September 16, 2024 22:04
@dreamorosi dreamorosi requested a review from a team as a code owner September 16, 2024 22:04
@dreamorosi dreamorosi merged commit 455d7b9 into main Sep 17, 2024
21 checks passed
@dreamorosi dreamorosi deleted the test/jmespath_vitest branch September 17, 2024 09:02
@dreamorosi dreamorosi linked an issue Sep 17, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation This item relates to automation dependencies Changes that touch dependencies, e.g. Dependabot, etc. internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) size/L PRs between 100-499 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: migrate test runner to vitest for jmespath package

2 participants