Skip to content

Fix fetching EKS AMI release archive #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Fix fetching EKS AMI release archive #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pkg/selector/eks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func (e *EKS) Filters(version string) (Filters, error) {
if e.AMIRepoURL == "" {
e.AMIRepoURL = eksAMIRepoURL
}
filters := Filters{}
var filters Filters

if version == "" {
var err error
Expand All @@ -51,9 +51,6 @@ func (e *EKS) Filters(version string) (Filters, error) {
version = eksFallbackLatestAMIVersion
}
}
if !strings.HasPrefix(version, "v") {
version = fmt.Sprintf("v%s", version)
}
supportedInstanceTypes, err := e.getSupportedInstanceTypes(version)
if err != nil {
log.Printf("Unable to retrieve EKS supported instance types for version %s: %v", version, err)
Expand All @@ -72,7 +69,7 @@ func (e *EKS) getSupportedInstanceTypes(version string) ([]string, error) {
}

defer resp.Body.Close()
if resp.StatusCode != 200 {
if resp.StatusCode != http.StatusOK {
return supportedInstanceTypes, fmt.Errorf("Unable to retrieve EKS supported instance types, got non-200 status code: %d", resp.StatusCode)
}

Expand Down Expand Up @@ -119,7 +116,7 @@ func (e EKS) getLatestAMIVersion() (string, error) {
if err != nil {
return "", err
}
if resp.StatusCode != 302 {
if resp.StatusCode != http.StatusFound {
return "", fmt.Errorf("Can't retrieve latest release from github because redirect was not sent")
}
versionRedirect := resp.Header.Get("location")
Expand Down